[dash] Convert pane close to St.Button, avoiding release event propagation

The workspaces was handling the release event after closing the pane,
catch it before closing by using St.Button.

diff --git a/js/ui/dash.js b/js/ui/dash.js
index fd5d947a99414a25de4e30995c2bcf2a7ec12cbb..3398fce9ed3eaf49759075b0020a68c1a6cf6f68 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -94,11 +94,9 @@ Pane.prototype = {
 
         let chromeTop = new St.BoxLayout();
 
-        let closeIcon = new St.Bin({ style_class: "dash-pane-close" });
-        closeIcon.reactive = true;
-        closeIcon.connect('button-press-event', Lang.bind(this, function (b, e) {
+        let closeIcon = new St.Button({ style_class: "dash-pane-close" });
+        closeIcon.connect('clicked', Lang.bind(this, function (b, e) {
             this.close();
-            return true;
         }));
         let dummy = new St.Bin();
         chromeTop.add(dummy, { expand: true });